GoogleCloudPlatform / oss-test-infra

https://oss-prow.knative.dev
Apache License 2.0
48 stars 132 forks source link

Update image locations to use new locations. #2341

Closed michelle192837 closed 1 month ago

michelle192837 commented 1 month ago

This includes three changes:

Images in gcr.io/k8s-staging-test-infra are public, but this requires that oss-prow has permissions to pull images from us-central1-docker.pkg.dev/gob-prow/prow-images. (I've granted permissions for oss-prow's default SA to view Artifact Registry in gob-prow, which I think should take care of it.)

michelle192837 commented 1 month ago

Updated reviewers. (Cole has context on the locations we're changing this to, and Sean your review is optional, but I know you saw some of the image location changes upstream).

simony-gke commented 1 month ago

/lgtm

Please make sure bump.sh can access us-central1-docker.pkg.dev/gob-prow/prow-images.

google-oss-prow[bot] commented 1 month ago

@simony-gke: changing LGTM is restricted to collaborators

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2341#issuecomment-2272392896): >/lgtm > >Please make sure bump.sh can access us-central1-docker.pkg.dev/gob-prow/prow-images. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
michelle192837 commented 1 month ago

Update bump.sh as well as the autobump config (I had local changes that didn't get saved).

google-oss-prow[bot] commented 1 month ago

@cjwagner: cat image

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2341#discussion_r1710146360): >/shrug >SGTM >/meowvie tools Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjwagner, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/OWNERS)~~ [cjwagner,michelle192837] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cjwagner commented 1 month ago

/unhold

google-oss-prow[bot] commented 1 month ago

@michelle192837: Updated the following 2 configmaps:

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2341): >This includes three changes: >- Upstream misc test-infra images are now published to gcr.io/k8s-staging-test-infra, so update image references to use that. gcr.io/k8s-prow > gcr.io/k8s-staging-test-infra >- Upstream Prow images use the gob-prow AR images that are maintained by the Prow dev team (and are separate from the ones published in k8s-sigs/prow). gcr.io/k8s-prow > us-central1-docker.pkg.dev/gob-prow/prow-images >- Autobump config needs to use the new locations, and has a split now to update the two different locations (for Prow and misc images). Prow images remain consistent, misc images don't have to. > >Images in gcr.io/k8s-staging-test-infra are public, but this requires that oss-prow has permissions to pull images from us-central1-docker.pkg.dev/gob-prow/prow-images. (I've granted permissions for oss-prow's default SA to view Artifact Registry in gob-prow, which I _think_ should take care of it.) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.