search

GoogleCloudPlatform / oss-test-infra

https://oss-prow.knative.dev
Apache License 2.0
48 stars 132 forks source link

Bump the Config Sync release branch to v1.19 #2356

Closed nan-yu closed 2 weeks ago

nan-yu commented 2 weeks ago

b/354790801

nan-yu commented 2 weeks ago

/assign @sdowell

nan-yu commented 2 weeks ago

/hold It needs to wait until feat: add github app auth to git-sync api is cherrypicked to the release branch.

sdowell commented 2 weeks ago

/hold It needs to wait until feat: add github app auth to git-sync api is cherrypicked to the release branch.

I think we could just merge this now and let the job fail until we cherry pick githubapp. Alternatively we could comment out the job and add it in after the cherry pick. Either way I think it would be preferable to get this change in asap

google-oss-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nan-yu, sdowell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[prow/prowjobs/GoogleContainerTools/kpt-config-sync/OWNERS](https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/prowjobs/GoogleContainerTools/kpt-config-sync/OWNERS)~~ [nan-yu,sdowell] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nan-yu commented 2 weeks ago

I think we could just merge this now and let the job fail until we cherry pick githubapp. Alternatively we could comment out the job and add it in after the cherry pick. Either way I think it would be preferable to get this change in asap

SGTM. The Config Sync 1.19 release branch is being created. Once it is done, we can do the cherrypick.

/unhold

google-oss-prow[bot] commented 2 weeks ago

@nan-yu: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2356): >b/354790801 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.