obriensystems
commented
1 year ago Triage older system for tf version
- add to the push cloud build yaml
root_@cloudshell:~/cloudshell_open/pbmm-on-gcp-onboarding (cnpe-cnd-cndev-sbx)$ git diff diff --git a/modules/cloudbuild/templates/cloudbuild-push-request.yaml b/modules/cloudbuild/templates/cloudbuild-push-request.yaml index 3495bbe..acc0fbf 100644 --- a/modules/cloudbuild/templates/cloudbuild-push-request.yaml +++ b/modules/cloudbuild/templates/cloudbuild-push-request.yaml @@ -14,6 +14,19 @@ steps: echo "*************************************************" terraform init || exit 1
+- id: 'tf version'
- name: ${_DEFAULT_REGION}-docker.pkg.dev/${_SEED_PROJECT_ID}/${_GAR_REPOSITORY}/terraform
- dir: "${_WORKSTREAM_PATH}"
- entrypoint: 'sh'
- args:
-
- '-c'
-
- |
- echo ""
- echo "*** TERRAFORM VERSION **"
- echo "* At environment: ${_WORKSTREAM_PATH} ***"
- echo "*****"
- terraform --version || exit 1
results https://console.cloud.google.com/cloud-build/builds;region=global/1ec94347-7cae-41f6-8d22-0d57878f2a08;step=1?project=cnpe-cnd-cndev-sbx&supportedpurview=projectTerraform v1.0.10 on linux_amd64
- provider registry.terraform.io/hashicorp/google v3.90.1
- provider registry.terraform.io/hashicorp/google-beta v4.50.0
- provider registry.terraform.io/hashicorp/null v3.2.1
- provider registry.terraform.io/hashicorp/random v3.4.3
Your version of Terraform is out of date! The latest version is 1.3.7. You can update by downloading from https://www.terraform.io/downloads.html
fmichaelobrien
20231014: see 1.0 specific issue that needs a 1.5 upgrade as a first step https://github.com/hashicorp/terraform-provider-google/issues/16217 and https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/issues/264
We will need to look at upgrading from 1.0 to 1.5.7 or the new 1.6.0 https://releases.hashicorp.com/terraform/1.6.0/ as a first step in the https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding codebase
20230724: Some private forks of this repo are working around the 1.3.7 issue by downgrading the client. While this is an ok fix and allows the initial bootstrap.sh to proceed - it does not fix the underlying issue that the code is only 1.0.10 compliant. The full fix is to upgrade the tf files to terraform 1.5.x This is in progress.
As part of working out perimeter/peering work in #220 Reproduction:
run any of the bootstrap, common, nprod, prod builds and you will fail on a currently built TF container. An older one from July 2022 will still work Getting last working terraform version - currently default to 1.0.10 in https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/blob/main/modules/cloudbuild/cloudbuild_builder/Dockerfile#L20
see Fix https://github.com/hashicorp/terraform/issues/31692 and https://github.com/hashicorp/terraform/issues/31355 first
In prep of the Terraform 1.4.0 release - on 5 Jan 2023 TF 1.3.7 introduced the breaking change on experimental use of optional(). This only breaks our bootstrap step in the PBMM LZ V1 LZ and the GR. The fix is to remove the experimental declaration for bootstrap so we can run in gcloud/shell again. For the gitops cloud build jobs - I'll keep these hardcoded to TF 1.0.10 for now until I refactor the defaults - so CB jobs are unaffected.
Fix is only required for bootstrap (which runs outside the CB container directly on the gcloud shell (which runs 1.3.7), for all other common/non-prod/prod we can continue to use terraform 1.0.10 and experimental optional attributes
Fix terraform version in the GitOps docker container
ARG TERRAFORM_VERSION=1.0.10
all terraform.tf
on new install to terraform.landing.systems
on existing install on cloudnuage.dev (last update was Nov 2023