GoogleCloudPlatform / pbmm-on-gcp-onboarding

GCP Canadian Public Sector Landing Zone overlay on top of the TEF via CFT modules - a secure cloud foundation
https://cloud.google.com/architecture/security-foundations
Apache License 2.0
41 stars 56 forks source link

Fix typo on 2nd DNS IP address on forwarding zone to on-prem - thanks George #293

Closed obriensystems closed 5 months ago

obriensystems commented 1 year ago

on top of #249 and #286

https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/blob/main/environments/prod/dns.tf#L96

https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/commit/64b92b4e0d81aa9457eb1be608a51c148b2a542e#diff-e786f41fff47bec09c1aa8908300e6672b88f088d711488c54e93e9b2a22ffdeR96

obriensystems commented 1 year ago

currently showing 1 IP address - need 2

Screenshot 2023-08-23 at 10 48 03
Step #3 - "tf plan":   # module.forwarding_zone.google_dns_managed_zone.forwarding[0] will be updated in-place
Step #3 - "tf plan":   ~ resource "google_dns_managed_zone" "forwarding" {
Step #3 - "tf plan":         id            = "projects/tzpe-tlz-tlzprod-host4/managedZones/dns-local"
Step #3 - "tf plan":         name          = "dns-local"
Step #3 - "tf plan":         # (7 unchanged attributes hidden)
Step #3 - "tf plan": 
Step #3 - "tf plan":       ~ forwarding_config {
Step #3 - "tf plan":           + target_name_servers {
Step #3 - "tf plan":               + forwarding_path = "default"
Step #3 - "tf plan":               + ipv4_address    = "8.8.4.4"
Step #3 - "tf plan":             }
Step #3 - "tf plan":             # (1 unchanged block hidden)
Step #3 - "tf plan":         }
Step #3 - "tf plan": 
Step #3 - "tf plan":         # (1 unchanged block hidden)
Step #3 - "tf plan":     }

Server location | Forwarding target type |  
-- | -- | --
8.8.4.4 | Default |  
8.8.8.8 | Default

</div></div></cfc-table-columns-presenter></div></cfc-table>
Screenshot 2023-08-23 at 10 54 37
fmichaelobrien commented 5 months ago

20240406: Closing issue during retrofit/rebase of this TEF V1 based/modified repo to TEF V4 standards This issue may participate in the LZ refactor after rebase Query on all issues related to the older V1 version via the tag https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/labels/2024-pre-tef-v4