search

GoogleCloudPlatform / pbmm-on-gcp-onboarding

GCP Canadian Public Sector Landing Zone overlay on top of the TEF via CFT modules - a secure cloud foundation
https://cloud.google.com/architecture/security-foundations
Apache License 2.0
45 stars 56 forks source link

Replaced real test values with dummy values #331

Closed jacyang2010 closed 1 year ago

jacyang2010 commented 1 year ago

Replaced real test values with dummy values.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

jacyang2010 commented 1 year ago

@fmichaelobrien Just made a quick fix to remove real test values. Please approve and merge it at your most convenience.

fmichaelobrien commented 1 year ago

Jackson let me know if you have rights to click "merge pull request" - after you accept "write" permissions - otherwise I will merge it right after