search

GoogleCloudPlatform / pbmm-on-gcp-onboarding

GCP Canadian Public Sector Landing Zone overlay on top of the TEF via CFT modules - a secure cloud foundation
https://cloud.google.com/architecture/security-foundations
Apache License 2.0
39 stars 55 forks source link

Fix bucket name length and make random suffix length variable for the hierarchical firewall #386

Closed mromascanu123 closed 2 months ago

mromascanu123 commented 2 months ago

For the GCS bucket aggregate the previous variable length suffix (which may end up in violating the max 63 chars rule) into a fixed length md5 string - this way the bucket name length is always the same regardless of the region name. Can be imbroved by passing the md5 through a base64 finction to reduce suffix length

Also incorporated for the hierarchical FW variable random suffix length (devault still 4)

google-cla[bot] commented 2 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

obriensystems commented 2 months ago

reference https://github.com/terraform-google-modules/terraform-example-foundation/issues/1190