search

GoogleCloudPlatform / pbmm-on-gcp-onboarding

GCP Canadian Public Sector Landing Zone overlay on top of the TEF via CFT modules - a secure cloud foundation
https://cloud.google.com/architecture/security-foundations
Apache License 2.0
38 stars 55 forks source link

Align PBMM and TEF repo on nonproduction, non-production and non_production identifiers - upstream and downstream #405

Open obriensystems opened 2 months ago

obriensystems commented 2 months ago

for example https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/3-networks-hub-and-spoke/envs/shared/remote.tf#L32

  nonproduction_folder_name         = data.terraform_remote_state.env_nonproduction.outputs.env_folder

resource "gitlab_branch_protection" "non_production" {
 tf_apply_branches = ["development", "non\\-production", "production"]

Align with PR from 3 weeks ago upstream https://github.com/terraform-google-modules/terraform-example-foundation/pull/1107 https://github.com/terraform-google-modules/terraform-example-foundation/commit/eb28ecb1ca659b1279db83b0b7f9667d56698c22#diff-446d88326ec6ad0370d30957f6546694390e92cc997a810e60783bfeb016efc1L308

https://github.com/terraform-google-modules/terraform-example-foundation/commit/eb28ecb1ca659b1279db83b0b7f9667d56698c22#diff-23e08ec4da208eb125d58a8b1323cce875ccbdb788f4d49eea5f7014eec91739L237

https://github.com/terraform-google-modules/terraform-example-foundation/commit/eb28ecb1ca659b1279db83b0b7f9667d56698c22#diff-fa3d339a1254d3cf877821545230e719f6877af71bdce95c0c7a2443cf6928e3L145

part of #376