search

GoogleCloudPlatform / pbmm-on-gcp-onboarding

GCP Canadian Public Sector Landing Zone overlay on top of the TEF via CFT modules - a secure cloud foundation
https://cloud.google.com/architecture/security-foundations
Apache License 2.0
44 stars 56 forks source link

As part of 421 - CB/local retrofit - verify no trailing . required for perimeter_additional_members like for the DNS peering domain - defaulting to no #422

Closed obriensystems closed 1 month ago

obriensystems commented 5 months ago

see

// Verify no appended . required on each user:*
perimeter_additional_members = ["user:USER_ID@DOMAIN."] # REPLACE ME (manually)

in https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/pull/384/files#diff-84c506ad22602993bb8b910d535d7f68385431629eb761daf75e69c38821aea4

https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/blob/main/3-networks-dual-svpc/common.auto.mod.tfvars#L23

see #421

obriensystems commented 5 months ago

https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/pull/423/commits/1178381aced2badb025f8a4f10d59d88f003f4a3

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days