Closed paumas closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.
. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ️ Googlers: Go here for more info.
@donmccasland can you review my pull request?
Taking a look. Thanks for your work!
Thanks @donmccasland. When can I expect release in production?
Looks like there are some build errors from the release I kicked off yesterday. I'll post log snippets today and we can start working through them.
On Wed, Dec 2, 2020 at 3:53 AM Paulius Masiliūnas notifications@github.com wrote:
Thanks @donmccasland https://github.com/donmccasland. When can I expect release in production?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/php-docker/pull/526#issuecomment-737183001, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF76UXHI7KZOITAJB6HMUTSSYTEFANCNFSM4TVOBNTQ .
Hi @donmccasland @paumas ,
Is this PR merged ? Because as you can see in pictures cloud build seems to be based on the 7.3 default. But the Github master branch is the 7.4 as default.
In my composer.json & .lock I have "php": "7.4.*"
Do you know why I cannot get php 7.4.* with Cloudbuild ?
CLOUDBUILD :
GITHUB :
No. This still isn't building due to problems with the one of the extension versions in composer. I think couchbase is the issue, but I'll have to go back to look when I have some time.
On Tue, Dec 22, 2020 at 2:43 AM HUSSON Kévin notifications@github.com wrote:
Hi, Is this PR merged ? Because as you can see in pictures cloud build seems to be based on the 7.3 default. But the Github master branch is the 7.4 as default. In my composer.json & .lock I have "php": "7.4.*"
CLOUDBUILD : [image: cloudbuild] https://user-images.githubusercontent.com/5119167/102879776-a74c5b80-444a-11eb-8011-ba4bb7695dfe.png
GITHUB : [image: github] https://user-images.githubusercontent.com/5119167/102879778-a7e4f200-444a-11eb-9456-07ad2142d257.png
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/php-docker/pull/526#issuecomment-749476513, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF76UU7MPIWTN3MYNP3H53SWBZ6VANCNFSM4TVOBNTQ .
Hey @donmccasland / @paumas - Has there been any update on the production release of this yet? :)
Looks like there are some build errors from the release I kicked off yesterday. I'll post log snippets today and we can start working through them. … On Wed, Dec 2, 2020 at 3:53 AM Paulius Masiliūnas @.***> wrote: Thanks @donmccasland https://github.com/donmccasland. When can I expect release in production? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#526 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF76UXHI7KZOITAJB6HMUTSSYTEFANCNFSM4TVOBNTQ .
I can't fix build, because @donmccasland don't share log snippets.
Hi @donmccasland,
Any update on this or any idea of the release date :) ?
Cheers
Hi @donmccasland,
Can I get google cloud build log file. I can try investigate, what the problem, why not build PHP 7.4 version.
Cheers.
I adding PHP 7.4.12, but i can't check if it works. How I can check?
I don't know how to change recode extension, because PHP 7.4 removed this extension. https://www.php.net/manual/en/migration74.removed-extensions.php https://www.php.net/manual/en/recode.installation.php
Note: Recode extension is unbundled and moved to » PECL as of PHP 7.4.0. Consider to use the Multibyte String or iconv extensions instead.