Closed frost-byte closed 3 years ago
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.
. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ️ Googlers: Go here for more info.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent.
in this pull request.
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla
label to yes
(if enabled on your project).
ℹ️ Googlers: Go here for more info.
I'm going to fix issues with the repo caused by removing the .cache file from the previous commits.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent.
in this pull request.
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla
label to yes
(if enabled on your project).
ℹ️ Googlers: Go here for more info.
Going to close this and resubmit it...
There is a lot to cover in this PR.
Here is a list of just some of the changes:
could not find libv8_libplatform library
There are a few things that still need to be reviewed:
set_by_lua
directive, I have switched to using the ppa from Ondrej for nginx-mainline v1.19; if I can determine enable the lua module for the package in bionic, then that can be used in its placeI have included a NOTES.md file containing some of the steps required to build packages, create distributions and build images. Some of this information is spread about in the previous release, but some was not clear.
Additional customizations have also been added, so you can specify your own GCS buckets and use your GCP Project ID to host the containers and package artifacts for the distributions you create for each PHP version supported.