search

GoogleCloudPlatform / php-docker

Docker images for running PHP applications on the App Engine Flexible Runtime
Apache License 2.0
188 stars 83 forks source link

ext-sodium PHP7.4 #536

Open SundayPlayer opened 3 years ago

SundayPlayer commented 3 years ago

I use a dependency that require ext-sodium: * . But in the PHP7.4 environment compiler tell me that this library is missing from the system.

Step to reproduce:

henryallsuch commented 3 years ago

I've been having the same issue here is what I have found: lib sodium is no longer a PECL extension, it's a compile time option so has to be enabled when php is compiled.

https://github.com/lcobucci/jwt/issues/717#issuecomment-813045094

Looks like the option has been added for 7.2 but that would not work for 7.3 or 7.4

https://github.com/GoogleCloudPlatform/php-docker/blob/0a50b38fcf45b15130c5d9ed7de45d816931ccbe/package-builder/build.sh#L68

Looks like https://github.com/GoogleCloudPlatform/php-docker/pull/533 they have included support for 7.4 and 8.0, though that would break 7.2 & 7.3 support.