fix: update message reflecting functionality of error_log

GoogleCloudPlatform / php-docs-samples

A collection of samples that demonstrate how to call Google Cloud services from PHP.

http://cloud.google.com/php

Apache License 2.0

957 stars 1.03k forks source link

fix: update message reflecting functionality of error_log #1936

Closed glasnt closed 3 months ago

glasnt commented 9 months ago

error_log flows through to Cloud logging, update message and comment.

Fixes b/286058340

glasnt commented 9 months ago

I think this PR is failing due to php-tools issues with identity, trying to access private functions.

glasnt commented 8 months ago

/gcbrun

glasnt commented 8 months ago

Looking into this more: it's not the deployment that's failing (as I previously guessed); it's the SystemTest that's failing, which uses CloudFunctionLocalTestTrait which tries to run the function locally.

See logs in https://github.com/GoogleCloudPlatform/php-docs-samples/pull/1943 where there's no changes, and the SystemTest fails.

I'm not able to replicate this specific error locally (though I am getting a different error kokoro isn't getting)

glasnt commented 8 months ago

After updating php-tools for the linked PR (or alternative solution), tests for this should succeed.

Keeping in draft until then.

glasnt commented 3 months ago

Ready for review ✨