GoogleCloudPlatform / point-of-sale

Anthos Edge Use Cases for bringing apps and computation closer to the location where the action is, to improve response times and save bandwidth.
Apache License 2.0
35 stars 18 forks source link

chore: move from Cloud KMS to Cloud Secrets #203

Closed Shabirmean closed 1 year ago

Shabirmean commented 1 year ago

Use Secrets manager instead of Cloud KMS

Shabirmean commented 1 year ago

/gcbrun

Shabirmean commented 1 year ago

/gcbrun

Shabirmean commented 1 year ago

/gcbrun

Shabirmean commented 1 year ago

/gcbrun

Shabirmean commented 1 year ago

/gcbrun

Shabirmean commented 1 year ago

/gcbrun

Shabirmean commented 1 year ago

/gcbrun

Shabirmean commented 1 year ago

Openned issue https://github.com/GoogleCloudPlatform/point-of-sale/issues/210 and closing this PR until we get resolution for the bug mentioned in that issue

Shabirmean commented 1 year ago

:zap: Two deployments have been created for the Point-of-Sale application. You may access and test them at: :zap:

Shabirmean commented 1 year ago

:zap: Two deployments have been created for the Point-of-Sale application. You may access and test them at: :zap:

Shabirmean commented 1 year ago

lgtm; nit: is it correct to assume that these environment variables are defined locally within Cloud Build configuration?

Yup. That's correct

Shabirmean commented 1 year ago

/gcbrun

Shabirmean commented 1 year ago

:zap: Two deployments have been created for the Point-of-Sale application. You may access and test them at: :zap: