search

GoogleCloudPlatform / professional-services-data-validator

Utility to compare data between homogeneous or heterogeneous environments to ensure source and target tables match
Apache License 2.0
399 stars 114 forks source link

chore: Upgrade package versions #1149

Closed nehanene15 closed 4 months ago

nehanene15 commented 4 months ago

Upgrade secret-manager to avoid conflicts with apache-airflow-providers-google when using Cloud Composer.

Closes #1147

conventional-commit-lint-gcf[bot] commented 4 months ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

nehanene15 commented 4 months ago

/gcbrun

moizarafat commented 4 months ago

@nehanene15 Thanks for the quick turn around. Could we also upgrade the versions for below to support >= same as apache-airflow-providers-google ?

google-cloud-bigquery google-cloud-bigquery-storage google-cloud-spanner google-cloud-storage google-api-python-client

nehanene15 commented 4 months ago

@nehanene15 Thanks for the quick turn around. Could we also upgrade the versions for below to support >= same as apache-airflow-providers-google ?

google-cloud-bigquery google-cloud-bigquery-storage google-cloud-spanner google-cloud-storage google-api-python-client

Yes, I checked those packages as well and DVT should not conflict with those.

helensilva14 commented 4 months ago

Fix #1091, #1092, #1140 - Merging will enable the closure for these other dependency-related PRs

gcf-merge-on-green[bot] commented 4 months ago

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

nehanene15 commented 4 months ago

Closing since this fix will be merged in #1150