GoogleCloudPlatform / professional-services-data-validator

Utility to compare data between homogeneous or heterogeneous environments to ensure source and target tables match
Apache License 2.0
397 stars 112 forks source link

any reason blocking non-BigQuery (or TEXT) result handler in config_manager.py #1210

Open scorpionjacky opened 1 month ago

scorpionjacky commented 1 month ago

In config_manager.py line 467 (copied below), any reason non-BigQuery (or TEXT) result handler is blocked?

        else:
            raise ValueError(f"Unknown ResultHandler Class: {result_type}")

Even though we can still use --format <type> for json, csv from the command line w/o using a configuration file, it does block these text result output when using config yaml file if the config file has:

result_handler:
  type: json

Changing the above lines like below unblocked it as I tested it:

        else:
            #raise ValueError(f"Unknown ResultHandler Class: {result_type}")
            return TextResultHandler(result_type)
helensilva14 commented 3 weeks ago

Hi @nj1973! Since you just worked on the result handler code for #1240, could you please take a look at this issue? It might be something we can incorporate in the same PR