fix: TD to BQ generate partitions with date PKs

GoogleCloudPlatform / professional-services-data-validator

Utility to compare data between homogeneous or heterogeneous environments to ensure source and target tables match

Apache License 2.0

400 stars 114 forks source link

fix: TD to BQ generate partitions with date PKs #1220

Closed nehanene15 closed 1 month ago

nehanene15 commented 1 month ago

Fixes #1191

Fixes rtrim() log message so that it only is logged when string comparison fields are present
Adds check for date columns in generate partitions so that date literals are generated. This will only affect date PKs.

nehanene15 commented 1 month ago

/gcbrun

sundar-mudupalli-work commented 1 month ago

/gcbrun

sundar-mudupalli-work commented 1 month ago

Hi,

I updated the generate partitions test case to include dates and datetime and both rendered correctly in the partition filters. I noticed that strings which have embedded quotes are not handled properly and opened issue 1221.

Otherwise good to go.

Sundar Mudupalli