GoogleCloudPlatform / professional-services-data-validator

Utility to compare data between homogeneous or heterogeneous environments to ensure source and target tables match
Apache License 2.0
408 stars 119 forks source link

fix: Hardcode SQLAlchemy max_identifier_length=128 for Oracle connections #1316

Closed nj1973 closed 2 weeks ago

nj1973 commented 2 weeks ago

I'm not happy about resorting to this "fix" because it is not really a fix.

Explanation of the problem this PR works around. This is a real edge case based on a number of colliding factors:

I've invested many hours trying to find an elegant solution and cannot really justify spending more time on it for such an edge case, especially one that will become less likely as we move further away from Oracle versions <= 12.1.

nj1973 commented 2 weeks ago

/gcbrun