search

GoogleCloudPlatform / professional-services-data-validator

Utility to compare data between homogeneous or heterogeneous environments to ensure source and target tables match
Apache License 2.0
407 stars 119 forks source link

fix: Issue 1325 #1328

Closed sundar-mudupalli-work closed 1 week ago

sundar-mudupalli-work commented 1 week ago

Hi,

Random Row validation was not possible due to a CLI bug introduced in PR 1310. Basically, the command line would only accept --use-random-row or -rr, while the backend could only understand use_random_rows which was always false because 'use_random_row' != 'use_random_rows'.

In order to not create a breaking change - the CLI accepts --use-random-row and -rr and translates them into use_random_rows, which the backend can understand.

We have tests for random rows, for multiple engines - they all bypass the CLI. We have a CLI unit test, but only for column validation. Random rows is an argument to Row validation, therefore opened issue 1327

Sundar Mudupalli

conventional-commit-lint-gcf[bot] commented 1 week ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

sundar-mudupalli-work commented 1 week ago

/gcbrun