search

GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
196 stars 92 forks source link

feat: add max throughput option #1028

Closed bernot-dev closed 5 months ago

bernot-dev commented 5 months ago

I'm wondering: does this have to live in Github? Could we use kustomize or helm to create the additional max-collector DaemonSet manifest as part of the GKE component internally by patching and duplicating the collector manifest?

The reason I'm asking is that users who self-install don't necessarily need two DaemonSet as they're free to adjust the one to meet their needs.

OTOH having two DaemonSets based on a node label is kind of a neat, resource optimization idea, even if the approach is rather coarse.

Thoughts?

I think there are perfectly reasonable cases for self-install scenarios to use both DaemonSets, including heterogeneous node sizes. And the overhead of one additional DaemonSet that is often Desired: 0 pods is a small price to pay. Self-install users who don't want the extra DaemonSet can easily delete it, as well. It may not be necessary for all users, but I don't think it hurts them.

TheSpiritXIII commented 5 months ago

I'm wondering if this has to live on GitHub as well. It's more effort for us to document this feature and have self-installed users set it up than it is for them to just edit the resources via Helm (which is already a variable on our configurations I belive) or via Kustomize.

bernot-dev commented 5 months ago

Decided to move this feature to examples for OSS use cases.