GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
189 stars 86 forks source link

fix: show warning when cleaning up old resources without delete permissions #1056

Closed TheSpiritXIII closed 2 weeks ago

TheSpiritXIII commented 1 month ago

Using the cleanup flag today causes the operator to crash-looping because we don't include the DELETE RBAC permission by default.

This happened because we used to do all resource creation/update/deletion on the operator but we moved it to YAML. This also makes the cleanup function consistent, as we warn when we can't delete everything else.