search

GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
189 stars 86 forks source link

feat: workload labels #1065

Closed bernot-dev closed 2 weeks ago

bernot-dev commented 1 month ago

Implement go/gmp:expand-target-labels.

bernot-dev commented 1 month ago

did you intend to change AlertingConfig?

Nope. That was my mistake. Should be fixed now.

pintohutch commented 2 weeks ago

FYI - we're still awaiting final word on if these labels are sufficient cc @xichen2020

bernot-dev commented 2 weeks ago

FYI - we're still awaiting final word on if these labels are sufficient cc @xichen2020

@pintohutch Is this blocking?

pintohutch commented 2 weeks ago

I don't think it's blocking this PR per se. We may want to wait on final labels before a release though