search

GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
191 stars 89 forks source link

fix: change data source syncer period to 10 minutes #1092

Closed lyanco closed 1 month ago

lyanco commented 1 month ago

fix: change data source syncer period to 10 minutes

Every 30 minutes meant that there could be at most 1 network timeout before losing connection. Running every 10 minutes instead makes it much less likely that a networking hiccup will cause Grafana to fail.

pintohutch commented 1 month ago

@lyanco - looks like the presubmit is failing.

I believe this is due to the recent helm templating migration @bernot-dev introduced. I believe you want to make the change in https://github.com/GoogleCloudPlatform/prometheus-engine/blob/1cb4afb3a875c1dbdb764d4c5d986a6ab773b27b/charts/datasource-syncer/templates/cronjob.yaml#L21, and run make regen. Adam can keep me honest.

bernot-dev commented 1 month ago

Interesting. Yes, looks like Bartek added datasource-syncer to the templating. I fixed this issue and pushed the updated version. Hopefully presubmits will pass this time.