search

GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
196 stars 93 forks source link

fix: Support target status for cadvisor #1098

Closed pintohutch closed 3 months ago

pintohutch commented 3 months ago

We had not tested ClusterNodeMonitoring-generated cadvisor scrape targets, which have an additional path suffix in the scrape pool. We consider that here when building the endpoint status and add a unit test.

This fixes #1097.

KapilBishnoi commented 3 months ago

@pintohutch in which version will this fix get released?

pintohutch commented 3 months ago

Hey @KapilBishnoi - we have not cut a release candidate with the fix yet. However, I think this will go in a 0.13.1 candidate tag. I will prioritize that this week.

KapilBishnoi commented 3 months ago

@pintohutch Thanks

pintohutch commented 3 months ago

Created https://github.com/GoogleCloudPlatform/prometheus-engine/releases/tag/v0.13.1-rc.0 to start the release pipeline.