search

GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
196 stars 92 forks source link

feat: allow environment variable for GMP Grafana datasource-syncer #1143

Closed xiangshen-dk closed 2 months ago

xiangshen-dk commented 2 months ago

It's requested by a customer who wants to pass the Grafana API token as an environment variable when deploy the datasource-syncer on Cloud Run.

The environment variable could have the API token as plain text or get the value from the GCP's Secret Manager service.

benholtz commented 1 month ago

Hi there, any chance we can get a container image built with this fix? looks like it was merged but there are no new published containers yet.

pintohutch commented 1 month ago

Hey @benholtz - apologies for the delay. We should be able to publish an image within a week. I'll post here with any updates.

pintohutch commented 1 month ago

Hey @benholtz - the datasource-syncer should be available for use now:

docker pull gke.gcr.io/prometheus-engine/datasource-syncer:v0.14.0-gke.0

Let us know if you have any questions or issues.

lyanco commented 1 month ago

Hey @benholtz - instructions have been updated, PTAL: https://cloud.google.com/stackdriver/docs/managed-prometheus/query#grafana-oauth