GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
196 stars 93 forks source link

feat: add /api/v1/rules endpoint #1149

Closed yama6a closed 2 months ago

yama6a commented 2 months ago

Adding a prometheus-compatible API endpoint to rule-evaluator: /api/v1/rules

Unfortunately I couldn't fully make use of make presubmit and make e2e - something makes Colima explode. 🤷 Please let me know if there's anything missing or not as expected/required.

yama6a commented 2 months ago

Thanks for the quick review! 🙂

I attended to your comments and got parts of the CI check to run on my machine to validate it. The issues should (hopefully) be resolved now.

yama6a commented 2 months ago

@bwplotka seems like something in the pipeline is failing. Running the failing bin step locally, I get the same error. Anything I can do on my end to fix it?

bwplotka commented 2 months ago

Don't worry about the error, fixing in https://github.com/GoogleCloudPlatform/prometheus-engine/pull/1155

I checked and rule-evaluator step was done, so we can safely merge https://github.com/GoogleCloudPlatform/prometheus-engine/actions/runs/10990949209/job/30521085208?pr=1149#step:3:234

pintohutch commented 1 month ago

Fixed #291