search

GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
195 stars 93 forks source link

0.9.0: Validation of Rule Failed #704

Open bwplotka opened 11 months ago

bwplotka commented 11 months ago

0.9.0 rule with project_id=gmp-eval-central selector fails to be applied:

Error from server (isolating rules failed: set isolation selector project_id="test_project" on up{cluster="gmp-test-recording-rules",project_id="gmp-eval-central"}: conflicting label matcher project_id="gmp-eval-central" found): error when creating "rules.yaml": admission webhook "[validate.rules.gmp-operator.gmp-system.monitoring.googleapis.com](http://validate.rules.gmp-operator.gmp-system.monitoring.googleapis.com/)" denied the request: isolating rules failed: set isolation selector project_id="test_project" on up{cluster="gmp-test-recording-rules",project_id="gmp-eval-central"}: conflicting label matcher project_id="gmp-eval-central" found
TheSpiritXIII commented 7 months ago

My 2-cents since we saw a customer report this issue recently: besides maybe rewording this error message, maybe we also shouldn't make it a hard error if they're using the correct values?