GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
191 stars 89 forks source link

[E2E refactor - 10] move e2e utils to dedicated pkg for future use #754

Closed pintohutch closed 7 months ago

pintohutch commented 8 months ago

I decided to break out the kind E2E test refactor PR https://github.com/GoogleCloudPlatform/prometheus-engine/pull/738 into smaller, digestible PRs for reviewing.

Note: because of the nature of the change, presubmits (i.e. Github Actions) may fail until the final PR is merged.

This is the tenth (and final!) one, where we move util packages out of e2e/ to a dedicated library in managed collection for future use.

TheSpiritXIII commented 7 months ago

Let's nuke it. I know where to look if we ever need these utilities back.

pintohutch commented 7 months ago

Thanks all!