rule-eval tests should check if rules are loaded to rule-eval, not only config map

GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.

https://g.co/cloud/managedprometheus

Apache License 2.0

195 stars 93 forks source link

rule-eval tests should check if rules are loaded to rule-eval, not only config map #765

Closed bwplotka closed 7 months ago

bwplotka commented 10 months ago

When checking testability of https://github.com/GoogleCloudPlatform/prometheus-engine/pull/763 I noticed we don't test on CI (when GCM option is off) if rules are ever loaded. Let's improve it e.g. by having a flag to skip readiness check of rule-eval for test purposes and checking API/metrics.