style: resolve linter errors and enable linter - Githubissues

GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.

https://g.co/cloud/managedprometheus

Apache License 2.0

195 stars 93 forks source link

style: resolve linter errors and enable linter #785

Closed bernot-dev closed 9 months ago

bernot-dev commented 9 months ago

Consolidated fixes after running linters on operator package.

Summary:

Unused arguments changed to _
k8s.io/utils/pointer is deprecated. Replace with k8s.io/utils/ptr.
error messages start with lowercase letter.
Exported functions have comments
Packages are only imported once (including aliases).
"if block ends with a return statement, so drop else and outdent its block"

Resolved or ignored (by line) linter errors and enabled default linters for golangci-lint, plus gofmt linter.

Enabled make lint in CI.