search

GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
195 stars 93 forks source link

chore: automate export.go version bump #863

Closed bernot-dev closed 8 months ago

bernot-dev commented 8 months ago

Automatically bump the version in export.go with release-please.

TheSpiritXIII commented 8 months ago

Do you know the order this happens in?

In order to have green builds, the release commit should have both the tag and this change at the same time or else unit tests fail. To do this in git, you have to push the tag before the commit so that the tag exists on the commit by the time the unit tests run.

bernot-dev commented 8 months ago

Hm...the version update would be in the PR, but the tag doesn't get created until the PR is merged. I wonder if the test needs to be reconsidered.

TheSpiritXIII commented 8 months ago

As discussed offline, could you remove the test now that we have this change? I believe you can just return empty string (and the comment) in the if Testing() block.