search

GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
195 stars 93 forks source link

fix(operator): add duplicate job name validation within PM, CPM and CNM #912

Closed bwplotka closed 7 months ago

bwplotka commented 7 months ago

Related to https://github.com/GoogleCloudPlatform/prometheus-engine/issues/479

Without this, certainly malformed CR could trigger Prometheus config parsing error, distrupting the whole cluster collection config changes.

Also to provide better fix to potentially #479 (vs creating separate CR) we could add e.g. JobNameSuffix field for endpoint, but that's for another PR.