GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
195 stars 93 forks source link

feat: Made config-reloader resilient to initial readiness server unavailability (5s default timeout). #946

Closed bwplotka closed 6 months ago

bwplotka commented 6 months ago

This should fix misleading restart of config-reloader which happeend in the past, yet giving us some extra guarantee when readiness url is misconfigured.

Alternative is to again - remove startup check logic and ensure our tests guards against misconfiguration of url in our manifests (or metric/alert on configuration not reloading, but's harder). Since the team was not comfortable with removal of readiness check, let's try something that will help in common case or config-reloader starting faster.