refactor(helm): remove updateversion and centralized one value file.

[bwplotka]

Changes

• Removed updateversion Make cmd
• Only use helm template once in a consistenst way.
• Added datasyncer (minimal templating)
• Added one values.global.yaml that contains all variables we care to change e.g. every release.
  • Moved all uninteresting settings to local values.yaml if applicable, wanted to make sure global file is changed on release only.

Rationales

• Avoid confusion. Ideally there is a single source of truth for images, resources etc for our OSS manifests. Right now it will be charts/values.global.yaml
• Avoid make updateversion unsafe templating. Use helm so we are a bit safer on templating.
  • It's easy to make mistake and sed something wrongly. For example the app Version module that perhaps suppose to change mainModuleVersion variable (I suppose?) @$(SED) -i -r 's# Version = .*# Version = "$(LABEL_API_VERSION)"#g' pkg/export/export.go was not matching anything.
  • We use Go template var where we expect things to be templated.

Open Questions

• Do we need such complex helpers? I don't get why we template a lot? Do we do something special on release/internally to explain this?
• We still don't template mainModuleVersion file, but we should likely do that differntly (e.g build tag) and updateversion was not working already.

[bernot-dev]

Completely agree that we now have better options than sed to update versions more safely.

Overall, I like this change. It's not clear to me that putting all of the images in a global file is the best solution, because it has to be manually included, and not all of the charts use all of those images. But it's probably fine because we're reducing the number of calls to helm template. And centralizing versions into one file has advantages, as well.

Since the versions are not included in the default values file now, I would consider making them required to make it noisier if the version is not supplied.

[bwplotka]

Addressed comments and simplified to one values.global.yaml -- simpler and consistent.