GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
191 stars 89 forks source link

chore: add requests and limits to initContainer #972

Open pintohutch opened 4 months ago

pintohutch commented 4 months ago

Avoids issues with Gatekeeper policies rejecting workloads that do not specify resource requests.

Note - the scheduler should not be affected, as the maximum of initContainers and containers is considered the effective request amount.

Also fixes a minor nit where we were setting the wrong container requests from the values file. We rename "collector" values to "prometheus" and fix the incorrect mapping in our helm charts.

pintohutch commented 4 months ago

Yea - I may hold off on merging. For some reason E2E tests are timing out with this change...