GoogleCloudPlatform / prometheus-engine

Google Cloud Managed Service for Prometheus libraries and manifests.
https://g.co/cloud/managedprometheus
Apache License 2.0
196 stars 92 forks source link

feat: deprecate the KubeletScraping field (backwards-compatible) #986

Open TheSpiritXIII opened 6 months ago

TheSpiritXIII commented 6 months ago

This helps avoid needing to add an OperatorConfig status field, since OperatorConfig no longer generates any configurations.

Now when KubeletScraping is set, a ClusterNodeMonitoring object is created automatically, reducing duplicated code. Users also have more control over the configuration, since they could change default values.

Later when we remove KubeletScraping, users would already have a ClusterNodeMonitoring so they will not lose their configurations.