search

GoogleCloudPlatform / prometheus-test-infra

Apache License 2.0
11 stars 3 forks source link

Parameterize the Prometheus configurations #19

Open saketjajoo opened 1 year ago

saketjajoo commented 1 year ago

It would be nice to have some or all of the Prometheus's command line arguments parameterized to have more flexibility over its deployment.

Code Reference:

  1. https://github.com/GoogleCloudPlatform/prometheus-test-infra/blob/master/prombench/manifests/prombench/benchmark/3b_prometheus-test_deployment.yaml#L66-L75
  2. https://github.com/GoogleCloudPlatform/prometheus-test-infra/blob/master/prombench/manifests/prombench/benchmark/3b_prometheus-test_deployment.yaml#L157-L166
bwplotka commented 1 year ago

I mean all the arguments

maxamins commented 1 year ago

@TheSpiritXIII Can we sync with using Kustomize to sync to prometheus-engine https://github.com/GoogleCloudPlatform/prometheus-engine/blob/main/cmd/operator/deploy/operator/10-collector.yaml#L90-L111

bwplotka commented 1 year ago

Kustomize or some simple tmpl - but it would be epic. Thanks for this issue 👍🏽