search

GoogleCloudPlatform / prometheus

The Prometheus monitoring system and time series database. GCP fork to export to Google Cloud Managed Service for Prometheus. Main branch is kept at parity with upstream - see branches or tags for Google's additions.
https://g.co/cloud/managedprometheus
Apache License 2.0
37 stars 15 forks source link

feat: allow updating export flags at runtime #180

Closed TheSpiritXIII closed 3 months ago

TheSpiritXIII commented 5 months ago

This PR allows you to set Google Cloud Monitoring API export-related flags in the configuration, as opposed to the CLI. The main motivation for this change is to eliminate UPDATE RBAC permissions which are otherwise required to update the CLI flags at runtime in a Kubernetes environment.

The following are now settable in the Prometheus config:

google_cloud:
  export:
    match: []string
    compression: string
    credentials: string

When both CLI arguments and configurations are present, the CLI arguments will be the default and the set configurations will override the CLI arguments.