search

GoogleCloudPlatform / prometheus

The Prometheus monitoring system and time series database. GCP fork to export to Google Cloud Managed Service for Prometheus. Main branch is kept at parity with upstream - see branches or tags for Google's additions.
https://g.co/cloud/managedprometheus
Apache License 2.0
37 stars 15 forks source link

Add test for missing make vendor run #183

Open bwplotka opened 5 months ago

bwplotka commented 5 months ago

Proposal

We constantly forget to do go mod vendor, no CI check for this?

bernot-dev commented 5 months ago

Usually the build fails if you don't run go mod vendor. We could add tidy and vendor to the regen target, I suppose?

pintohutch commented 5 months ago

It's actually a part of the make regen target already, which calls the presubmit.sh script to execute various commands.

pintohutch commented 5 months ago

Oh - and in Github CI in the validate step, where it ensures there's no diff after running.

Could potentially be improved though :)