search

GoogleCloudPlatform / pubsec-declarative-toolkit

The GCP PubSec Declarative Toolkit is a collection of declarative solutions to help you on your Journey to Google Cloud. Solutions are designed using Config Connector and deployed using Config Controller.
Apache License 2.0
32 stars 28 forks source link

[ENHANCEMENT] full workaround for #103 where we .krmignore the policy folders that block the landing-zone solution #114

Open fmichaelobrien opened 2 years ago

fmichaelobrien commented 2 years ago

Describe the bug A better fix/enhancement for getting policy deployments working in the landing-zone solution

undo adding

environments/common/guardrails-policies
environments/common/general-policies/naming-rules

in https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/blob/main/solutions/landing-zone/.krmignore#L1

to avoid

michael@cloudshell:~/github/GoogleCloudPlatform/pubsec-declarative-toolkit (landing-zone-controller-1z583)$ kpt live apply landing-zone --reconcile-timeout=2m --output=table
Error: 4 resource types could not be found in the cluster or as CRDs among the applied resources.

Resource types:
constraints.gatekeeper.sh/v1beta1, Kind=NamingPolicy
constraints.gatekeeper.sh/v1beta1, Kind=DataLocation
constraints.gatekeeper.sh/v1beta1, Kind=LimitEgressTraffic
constraints.gatekeeper.sh/v1beta1, Kind=CloudMarketPlaceConfig

See linking to existing #103 and the PR https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/pull/107

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

cartyc commented 2 years ago

Documenting in #129

fmichaelobrien commented 1 year ago

Check fix from Luc or Alain