GoogleCloudPlatform / pubsec-declarative-toolkit

The GCP PubSec Declarative Toolkit is a collection of declarative solutions to help you on your Journey to Google Cloud. Solutions are designed using Config Connector and deployed using Config Controller.
Apache License 2.0
30 stars 27 forks source link

TOC: Fully parameterize the region across the code - to handle a mix or only nane1 or nane2 #791

Open fmichaelobrien opened 5 months ago

fmichaelobrien commented 5 months ago

By design because of the historical preference to nane1 - some of the config is hardcoded to region 1. an example is in https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/pull/781 in https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/blob/main/solutions/experimentation/core-landing-zone/lz-folder/audits/logging-project/cloud-storage-buckets.yaml#L30

spec:
  # enable autoclass
  # https://cloud.google.com/storage/docs/autoclass
  autoclass:
    enabled: true
  location: northamerica-northeast1

There are times when these remaining region settings must be aligned with nane2 including a recent client request.

Push changes in phases by package and CI/CD test each package PR - starting with core-landing-zone

fmichaelobrien commented 5 months ago

Add regionalization to both the script and the setters.yaml for client-landing-zone at

https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/blob/main/solutions/client-landing-zone/setters.yaml#L147

566

https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/blob/gh766-script/solutions/setup.sh#L351

  allowed-os-update-domains: |
    - "debian.map.fastlydns.net"
    - "debian.org"
    - "deb.debian.org"
    - "ubuntu.com"
    - "cloud.google.com"
    - "packages.cloud.google.com"
    - "security.ubuntu.com"
    - "northamerica-northeast1.gce.archive.ubuntu.com"
    - "northamerica-northeast2.gce.archive.ubuntu.com"
obriensystems commented 4 months ago

client-project-setup use of subnets in the host project in client-landing-zone with 2 sets of 2 subnets (nonp and pbmm across nane1 and nane2) - already set

https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/blob/main/solutions/client-landing-zone/client-folder/standard/applications-infrastructure/host-project/network/subnet.yaml#L26