GoogleCloudPlatform / pubsec-declarative-toolkit

The GCP PubSec Declarative Toolkit is a collection of declarative solutions to help you on your Journey to Google Cloud. Solutions are designed using Config Connector and deployed using Config Controller.
Apache License 2.0
30 stars 27 forks source link

fix: workflow validate-solutions #792

Closed alaincormier-ssc closed 5 months ago

alaincormier-ssc commented 5 months ago

The validate-solutions workflow takes longer to run than usual

The cause appears to point to the checkout action behaving differently since updating from v1 to v4 in PR #696

In v4, only a single commit is fetched by default, this causes the workflow to get fatal: bad revision 'origin/main' errors when verifying the diff from origin/main, which then causes all solutions to be validated whether it changed or not

To fix this, it's possible to set fetch-depth to 0, which will fetch all branches