search

GoogleCloudPlatform / pubsec-declarative-toolkit

The GCP PubSec Declarative Toolkit is a collection of declarative solutions to help you on your Journey to Google Cloud. Solutions are designed using Config Connector and deployed using Config Controller.
Apache License 2.0
30 stars 26 forks source link

Ambiguity: client-project-setup setters.yaml - detail which of 2 main subnets (nonp or pbmm) out of 4 to target - depends on parent folder pbmm/nonp - replacement of classification stub #830

Open obriensystems opened 4 months ago

obriensystems commented 4 months ago

https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/blob/main/solutions/client-project-setup/setters.yaml#L82

  allowed-nane1-main-subnet: host-project-id-nane1-standard-classification-main-snet
  allowed-nane2-main-subnet: host-project-id-nane2-standard-classification-main-snet

link with folder name from #829 

 project-parent-folder: project-parent-folder

like the following

# nonp in below replaces "classification"
nane1-standard-${project-parent-folder}-main-snet

export CLIENT_PROJECT_PARENT_FOLDER=nonp
#export CLIENT_CLASSIFICATION=pbmm
export CLIENT_CLASSIFICATION=nonp
  allowed-nane1-main-subnet: net-host-project-${PREFIX_CLIENT_LANDING_ZONE}-nane1-standard-${CLIENT_CLASSIFICATION}-main-snet
  allowed-nane2-main-subnet: net-host-project-${PREFIX_CLIENT_LANDING_ZONE}-nane2-standard-${CLIENT_CLASSIFICATION}-main-snet

  however the subnets area actually of the format - without project name
  nane1-standard-nonp-main-snet
Screenshot 2024-02-13 at 17 04 20

from https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/blob/main/solutions/client-landing-zone/client-folder/standard/applications-infrastructure/host-project/network/subnet.yaml#L26

  name: net-host-project-cso3-nane1-standard-nonp-main-snet # kpt-set: ${host-project-id}-nane1-standard-nonp-main-snet
${host-project-id}-nane1-standard-nonp-main-snet