GoogleCloudPlatform / pubsec-declarative-toolkit

The GCP PubSec Declarative Toolkit is a collection of declarative solutions to help you on your Journey to Google Cloud. Solutions are designed using Config Connector and deployed using Config Controller.
Apache License 2.0
30 stars 26 forks source link

Hardcoded projects in compute.trustedImageProjects org policy override in hub-env #845

Open obriensystems opened 4 months ago

obriensystems commented 4 months ago

Fixing https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/blob/main/solutions/project/hub-env/org-policies/exceptions/compute-trusted-image-projects-except-hub-project.yaml#L41

      values:
        - "projects/fortigcp-project-001"
        - "projects/windows-cloud"

should be kpt rendered via

      values:
        - under:projects/PROJECT_ID # kpt-set: under:projects/${hub-project-id}

There are 3 more similar hardcoding issues i will raise for https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/tree/main/solutions/project/hub-env/org-policies/exceptions