GoogleCloudPlatform / pubsec-declarative-toolkit

The GCP PubSec Declarative Toolkit is a collection of declarative solutions to help you on your Journey to Google Cloud. Solutions are designed using Config Connector and deployed using Config Controller.
Apache License 2.0
31 stars 28 forks source link

fix: t34 resources require updates to folder structure for syncs #906

Closed Michael-McAuley-SSC closed 6 months ago

Michael-McAuley-SSC commented 6 months ago

Describe the bug "\<x-fleet-id>" and "\<namespace>" references do not render properly in some ci/cd/git repos

To Reproduce Steps to reproduce the behavior:

1, kpt pkg get a t34 resource

  1. Create a PR on that resource
  2. Examine the PR and note that the paths do not render correctly

Expected behavior Complete and proper rendering

Screenshots

Additional context This issue does not affect github, but in practical terms rendering special characters should not be an expectation. The fix for this bug will address the issues.

Note: This bug is actually affecting the comments section for this bug, double quotes and "\" escapes were needed to render this comment.