search

GoogleCloudPlatform / python-docs-samples

Code samples used on cloud.google.com
Apache License 2.0
7.46k stars 6.44k forks source link

healthcare.api-client.fhir.fhir_stores_test: test_get_set_fhir_store_iam_policy failed #3073

Closed flaky-bot[bot] closed 4 years ago

flaky-bot[bot] commented 4 years ago

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and I will stop commenting.

buildID: fadb04c4dda27b77fe743c54f3634d7b637bce9e buildURL: Build Status, Sponge status: failed

flaky-bot[bot] commented 4 years ago

Test passed in build 63e99d6687ce4c2a5b44cce94750e05dcc982486 (Build Status, Sponge)! Closing this issue.

flaky-bot[bot] commented 4 years ago

Looks like this issue is flaky. :worried:

I'm going to leave this open and stop commenting.

A human should fix and close this.

commit: 4cc234cc28d7922e0a5a0cfe136b36a019e8ccad buildURL: Build Status, Sponge status: failed

tmatsuo commented 4 years ago

It passes locally with few administrative operations:

I'll do those and mark this as fixed.

tmatsuo commented 4 years ago

I added a role "Healthcare FHIR Store Administrator" to python-docs-samples-tests@appspot.gserviceaccount.com. I'm not sure it's the cause because the service account was already an "editor" of the project.

I found out that a service account "service-1012616486416@gcp-sa-healthcare.iam.gserviceaccount.com" is already a storage admin on a bucket "python-docs-samples-tests"

Probably the test is really flaky.

tmatsuo commented 4 years ago

I found out that the build log at: https://source.cloud.google.com/results/invocations/e836c3f6-a5a8-497e-8903-7f0844f8809e/log

has the following:

WARNING  googleapiclient.http:http.py:118 Invalid JSON content from response: b'{\n  "error": {\n    "code": 403,\n    "message": "Permission healthcare.fhirStores.create denied on resource projects/python-docs-samples-tests/locations/us-central1/datasets/test_dataset_1583863544 (or it may be malformed or not exist)",\n    "status": "PERMISSION_DENIED"\n  }\n}\n'

I hope the test is now fixed by adding "Healthcare FHIR Store Administrator".

tmatsuo commented 4 years ago

One of the tests still uses time.time(), so I'll make a fix and see how the test goes there.