Feature Depends on functionalities and Set mandatory fields via UI Meta flag

GoogleCloudPlatform / rad-lab

RAD Lab enables users to deploy infrastructure on Google Cloud Platform (GCP) to support specific use cases. Infrastructure is created and managed through Terraform in conjunction with support scripts written in Python. The templates, code, and documentation for each use case are bundled into modules.

Apache License 2.0

95 stars 81 forks source link

Feature Depends on functionalities and Set mandatory fields via UI Meta flag #187

Open saurabhkg891 opened 1 year ago

saurabhkg891 commented 1 year ago

Depends on functionalities and Set mandatory fields via UI Meta flag

Resolving issues: #140

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

github-actions[bot] commented 1 year ago

Thank you for raising the request! RAD Lab admins have been notified.

github-actions[bot] commented 1 year ago

Apache 2.0 License check successful!

acolver commented 1 year ago

@saurabhkg891 When I toggle a checkbox it (correctly) shows more fields that are required. However, if I uncheck I cannot click "Next" until I trigger a blur event. (see screenshot). Can we have the form validation run onChange instead of onBlur?

acolver commented 1 year ago

@saurabhkg891 Also, if I have an invalid form (e.g. haven't filled out some required fields) and I click "Previous", the previous--valid--form won't let me click "Next" until I retrigger validation (e.g. uncheck and recheck a box)