search

GoogleCloudPlatform / recaptcha-enterprise-flutter

Apache License 2.0
23 stars 8 forks source link

Added isCustomAction boolean to execute method for passing customActon #5

Closed alexanderkorus closed 1 year ago

alexanderkorus commented 1 year ago

Hi,

currently it isn't possible to pass a customAction "Login" to the SDK, because this action parsed as default action. We defined a customAction also called "Login", so it needs to be passed to the enterprise SDK as customAction. To enable this scenario, I added isCustomAction boolean to execute method for passing customActon with similar RecaptchaAction like "login".

This is a quick fix, if you consider a cleaner solution, you could introduce a RecaptchaAction Data class also on the flutter side.

Greets, Alex

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mcorner commented 1 year ago

We aren't accepting code contributions for this repo (this is actually just a mirror of an internal repo)

That said can you open a feature request in issues and we can discuss it?