search

GoogleCloudPlatform / recommender-iac-pipeline-nodejs-tutorial

Apache License 2.0
11 stars 18 forks source link

Patching several bugs that exists in the code #8

Closed idofl closed 3 years ago

idofl commented 3 years ago
  1. Added x-goog-user-project to run recommendation API in the test project, instead of in the build project
  2. Passing location from Cloud Scheduler to Cloud Run to provide location for VM recommendations
  3. Fetching project numbers by project IDs to enable IAM state vs. recommendation comparison (TF state uses IDs and recommendations use numbers) + ignore for stub as it uses IDs for the recommendation
idofl commented 3 years ago
  1. Fixing the stub json structure to resemble a real recommendation (and the code as a result)