GoogleCloudPlatform / reliable-task-scheduling-compute-engine-sample

Apache License 2.0
146 stars 137 forks source link

Updating the GAE app to work out of the box #4

Closed nigeldunn closed 8 years ago

nigeldunn commented 8 years ago

I ran into the following issues when I tried to use the GAE part of this repo:

These changes make the GAE component work out of the box again albeit with a throw away "test" message.

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

nigeldunn commented 8 years ago

I've signed CLA's on 3 different accounts now but I'm still seeing: cla/google — Need a CLA for one or more commit authors

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

nigeldunn commented 8 years ago

I authored the commits.

tswast commented 8 years ago

Thanks. These changes look good to me.

I'll ask one of my teammates to review to make sure the code runs. (I'll have to make sure to add some automated Travis tests for this repo.)

lesv commented 8 years ago

@tswast Can you do this?

tswast commented 8 years ago

Looking now.

tswast commented 8 years ago

Thank you for your contribution!

I verified that these changes fix the App Engine deployment. Merging now.