search

GoogleCloudPlatform / ruby-docker

Ruby runtime for Google Cloud Platform
Apache License 2.0
134 stars 56 forks source link

Is the Ruby version of `ruby-pipeline/ruby-latest.yaml` correct? #214

Closed satoshicano closed 2 years ago

satoshicano commented 2 years ago

In #212, some versions has been added, but it looks like the version is wrong.

Specifically, it is on the following line. (Isn't it correct 2.6.9?)

https://github.com/GoogleCloudPlatform/ruby-docker/blob/ca02007c83a9bd146cb4415115a455ce56a13cc7/ruby-pipeline/ruby-latest.yaml#L64

Is this a deliberate change?

If not, is it okay to create a PR?

amurciasu commented 2 years ago

Hey! Yes, you are right.

https://github.com/GoogleCloudPlatform/ruby-docker/pull/215

dazuma commented 2 years ago

Thanks for catching this. I merged the PR and will rebuild the runtime within the next day.

dazuma commented 2 years ago

Was able to expedite the runtime release. This should be fixed now. Apologies for the typo!

satoshicano commented 2 years ago

Thanks all for the lighting fast release!